Nickel.dinky, line 109: obj.photo_name <- “a newspaper headline”
This line needs to be wrapped in TEXT(), I suppose. We get no translation otherwise.
The same goes for Bathroom.dinky, lines 273, 274, 281, 282. Diner.dinky, lines 43 and 78. DefineActors.dinky, line 288 (both entries for Lenore).
EDIT: also Alleyway.dinky, line 158. If you dissolve the glue from the poster, Ransome’s poster gets an unwrapped name while it does if you scrape it with the screwdriver.
I’d also say we need to wrap and create translation entries for the options in Settings.dinky, lines 334-340.
You missed one the Nickel.dinky. I made a pull request for the fix.
When we’re done (and we’re almost done, all the lines are translated but we need to playtest them) then it will be time to think of the options and how to switch.
When you do a pull request for a missing wrapped line, can you also give it a new line id and add the text to the _en.tsv file. That way I don’t have to pull and rerun the extractor. Just use the next free line id.
If an object isn’t assigned explicitly an article, it gets assigned the article “a”, entry 11981 (see Inventory.dinky, row 129) when you look a picture, so if you take a picture of “bottle” and then look the picture, it says “it’s a photo of” + “a” + “bottle”.
And that’s a problem because having only one entry is fine for English, but not for gendered languages.
Now… how do we solve this? We could add explicit article entries for all objects (some already have, like all the notes posted outside the Nickel News in A Street), but it would take quite some time.
If we want to do it extensible, as all TWP languages are gendered, we could add a gender entry to the object. But genders change from language to language, and it must be so extensible that it’s easy to know which gendered translation to take for each language.
So probably the explicit article entry is the best way… I don’t know.
It’s a good thing no one is translating this to Finnish. It has no genders nor articles…
(Finnish has no prepositions, but instead a complex system of postpositions)
Apropos prepositions: Italian has prepositions that merge with the articles. So, when constructing a sentence with code, like “talk to” + article + noun, one must be careful. “Talk to” can be “parla a”, but then if you have “the Sheriff”, “parla a lo sceriffo” sounds awful, as “a lo” merges into “allo”. So I opted for “parla con” (talk with) because “con” is usually left unmerged.
The same goes for the photos. When you look at a picture, Delores says “it’s a photo of”. “È una foto di” isn’t an appropriate translation, because “di” is ALWAYS merged. “Una foto di lo sceriffo” makes no sense. So I opted for “una foto che ritrae”, “a photo that depicts”, so I can put all the articles I want.
Unless… is it possible to “intercept” the object name’s text ID?
So like “map” has name = TEXT(11457,“bottle”). Is there a way of getting 11457?
If so, one could add entries like 10*ID (114570) to specify a custom article. Instead of adding “a” by default, it first tries to see if ID*10 exists and if so it uses that article.
You still have to go though and add all the articles. I feels more flexible to just add them in the code. It’s Just a bunch of pasting article = TEXT(0,“a”) in all the objects. It’s going to be a challenge for a translator (that is also not a programmer) to figure out what is what. If it had been done initially, at lease the lines would appear next to each other in the ,tsv file.
The .tsv gets overwritten every time or is it in append only? Because the English reference in the third column of each .tsv file could then be used to help other translators once the entries are created.
Anyway, I need to add it to those objects that don’t have neither no_photo attribute nor photo_name so maybe it’s fewer than expected
Yes, different languages can be a challenge for a fixed system. In Finnish:
Talk to the Sheriff -> (in basic form) Puhu Sheriffille (notice the omit of the)
but that’s a bit rude, and I would say “Juttele Sheriffin kanssa” (“Chat Sheriff with”).
The same goes for photos: “It’s a photo of the Sheriff” would be “Se on kuva Sheriffistä”.
But, “It’s a photo of a bottle” -> “Se on kuva pullosta”.
The real difficulty is something like “It’s a photo of a boat” -> “Se on kuva veneestä”, where vene is a boat, but post position is not venestä, but veneestä.
Interestingly enough, the lack of article creates a funny error in English too.
If you take a picture of Ransome’s candy dispensers in the Quickie Pal, Delores says “It’s a photo of a Ransome candy dispensers” I’ll add “some” as article in this case.
EDIT: to keep consistency with the rest of the code, I’ll add photo_name = “Ransome candy dispensers” instead of an article